third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp - Issue 2169433002: HTMLTreeBuilderSimulator: Element created inside HTMLIntegrationPoint should be HTMLElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

Issue 2169433002: HTMLTreeBuilderSimulator: Element created inside HTMLIntegrationPoint should be HTMLElement Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp » ('j') | third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

index 67e9caff836c76efa3d406a4058f54b028526890..21cdc5ff5a4f445d381aade18299b53796f5d955 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

@@ -175,14 +175,16 @@ HTMLTreeBuilderSimulator::SimulatedToken HTMLTreeBuilderSimulator::simulate(cons

if (inForeignContent() && tokenExitsForeignContent(token))

m_stack.removeLast();

- if (threadSafeMatch(tagName, SVGNames::svgTag))

+ if (currentNodeIsHTMLIntegrationPoint)

+ m_stack.append(StateFlags {HTML, false});

dominicc (has gone to gerrit) 2016/07/21 02:14:48 Why don't we need a matching change to "pop" this?

+ else if (threadSafeMatch(tagName, SVGNames::svgTag))

m_stack.append(StateFlags {SVG, tokenStartsHTMLIntegrationPoint(token)});

else if (threadSafeMatch(tagName, MathMLNames::mathTag))

m_stack.append(StateFlags {MathML, tokenStartsHTMLIntegrationPoint(token)});

else if ((currentNodeNamespace == SVG && tokenExitsSVG(token))

|| (currentNodeNamespace == MathML && tokenExitsMath(token)))

m_stack.append(StateFlags {HTML, tokenStartsHTMLIntegrationPoint(token)});

- else if (elementMayBeHTMLIntegrationPoint(token.data()) != currentNodeIsHTMLIntegrationPoint)

+ else if (elementMayBeHTMLIntegrationPoint(token.data()))

m_stack.append(StateFlags {static_cast<unsigned>(currentNodeNamespace), tokenStartsHTMLIntegrationPoint(token)});

if (!inForeignContent() || currentNodeIsHTMLIntegrationPoint) {