Source/core/dom/Document.cpp - Issue 21694005: Spell check whole content of an editable element when it gets focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 21694005: Spell check whole content of an editable element when it gets focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: async test added. Sync suffixed with -sync Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync-expected.txt ('k') | Source/core/editing/Editor.h » ('j') | Source/core/editing/Editor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 888dce0df80c89e8e39ddb4ff5dbda141dc35d82..87753afde19219ebb604592b28d85ea0881db5f9 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -3294,7 +3294,7 @@ bool Document::setFocusedElement(PassRefPtr<Element> prpNewFocusedElement, Focus

}

if (oldFocusedElement->isRootEditableElement())

- frame()->editor()->didEndEditing();

+ frame()->editor()->didEndEditing(oldFocusedElement.get());

if (view()) {

Widget* oldWidget = widgetForElement(oldFocusedElement.get());

@@ -3343,7 +3343,7 @@ bool Document::setFocusedElement(PassRefPtr<Element> prpNewFocusedElement, Focus

m_focusedElement->setFocus(true);

if (m_focusedElement->isRootEditableElement())

- frame()->editor()->didBeginEditing();

+ frame()->editor()->didBeginEditing(m_focusedElement.get());

// eww, I suck. set the qt focus correctly

// ### find a better place in the code for this