Spell check whole content of an editable element when it gets focused.

Source/core/editing/Editor.h

Index: Source/core/editing/Editor.h
diff --git a/Source/core/editing/Editor.h b/Source/core/editing/Editor.h
index 053c3879df0890f10a76c38c05fac7a88a32081e..83fe6c8b29d7c93d7a992ab09f824ef982cbc4f7 100644
--- a/Source/core/editing/Editor.h
+++ b/Source/core/editing/Editor.h
@@ -214,8 +214,8 @@ public:
     bool canRedo();
     void redo();
 
-    void didBeginEditing();
-    void didEndEditing();
+    void didBeginEditing(Element*);
+    void didEndEditing(Element*);

[tony, 2013/08/20 22:10:39]

It doesn't look like we use Element in didEndEditing.

 
     void setBaseWritingDirection(WritingDirection);
 
@@ -281,7 +281,7 @@ public:
     bool markedTextMatchesAreHighlighted() const;
     void setMarkedTextMatchesAreHighlighted(bool);
 
-    void textFieldDidBeginEditing(Element*);
+    void textAreaOrTextFieldDidBeginEditing(Element*);
     void textFieldDidEndEditing(Element*);
     void textDidChangeInTextField(Element*);
     bool doTextFieldCommandFromEvent(Element*, KeyboardEvent*);
@@ -309,6 +309,10 @@ public:
     };
     friend class RevealSelectionScope;
 
+    // Spell checks whole contents of a editable element (<input="text"/>, <textarea> or contenteditable)
+    // This gets called when any editable element gets focused.

[tony, 2013/08/20 22:10:39]

I would remove this comment.  It's a 'what' comment instead of a 'why' comment
and it seems like it would easily get out of date.

+    void elementDidBeginEditing(Element*);
+
 private:
     RefPtr<CompositeEditCommand> m_lastEditCommand;
     RefPtr<Node> m_removedAnchor;
@@ -321,6 +325,7 @@ private:
     bool m_areMarkedTextMatchesHighlighted;
     EditorParagraphSeparator m_defaultParagraphSeparator;
     bool m_overwriteModeEnabled;
+    Vector<RefPtr<Node> > m_editablesSpellCheckedOnFocus;

[tony, 2013/08/20 22:10:39]

This should be a HashSet, not a Vector.

Also, why do you hold a ref?  If someone removes the node from the DOM, the ref
is going to keep it alive until the page is unloaded.

Even if you switch it to a HashSet<Node*>, it seems like it's possible for
unbounded growth if you dynamically create editable areas.  On a site like
gmail, that's bad.

[pstanek, 2013/08/21 06:05:18]

I was thinking the same i.e. it's only a key so Node* would do but then I looked
how spelling and grammar markers are kept. They also keep refs in their hashset
which also looks unneeded so I came to conclusion that I might not know
something and there is some reason behind this so I used refs here as well.

 
     bool canDeleteRange(Range*) const;
     bool canSmartReplaceWithPasteboard(Pasteboard*);