Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: media/capture/video/file_video_capture_device_factory.h

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactoring of VideoCaptureDeviceFactory interface Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/file_video_capture_device_factory.h
diff --git a/media/capture/video/file_video_capture_device_factory.h b/media/capture/video/file_video_capture_device_factory.h
index 8d99a28b88bf722942a20a0dba5eb328a9d5af38..048fed1f75752305deca4343595cbe396c8f2c71 100644
--- a/media/capture/video/file_video_capture_device_factory.h
+++ b/media/capture/video/file_video_capture_device_factory.h
@@ -12,6 +12,9 @@ namespace media {
// Extension of VideoCaptureDeviceFactory to create and manipulate file-backed
// fake devices. These devices play back video-only files as video capture
// input.
+// The |device_descriptor.friendly_name| passed into the Create() method is
+// interpreted as a (platform-specific) file path to a video file to be used as
+// a source.
class CAPTURE_EXPORT FileVideoCaptureDeviceFactory
: public VideoCaptureDeviceFactory {
public:
@@ -19,11 +22,16 @@ class CAPTURE_EXPORT FileVideoCaptureDeviceFactory
~FileVideoCaptureDeviceFactory() override {}
std::unique_ptr<VideoCaptureDevice> Create(
- const VideoCaptureDevice::Name& device_name) override;
- void GetDeviceNames(VideoCaptureDevice::Names* device_names) override;
+ const VideoCaptureDeviceDescriptor& device_descriptor) override;
+ void GetDeviceDescriptors(
+ VideoCaptureDeviceDescriptors* device_descriptors) override;
+ void GetDeviceInfo(const VideoCaptureDeviceDescriptor& device_descriptor,
+ VideoCaptureDeviceInfo* device_info) override;
+
+ private:
void GetDeviceSupportedFormats(
- const VideoCaptureDevice::Name& device,
- VideoCaptureFormats* supported_formats) override;
+ const VideoCaptureDeviceDescriptor& device_descriptor,
+ VideoCaptureFormats* supported_formats);
};
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698