media/capture/video/linux/v4l2_capture_delegate.h - Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/linux/v4l2_capture_delegate.h

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring of VideoCaptureDeviceFactory interface Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_manager.cc ('K') | « media/capture/video/file_video_capture_device_factory.cc ('k') | media/capture/video/linux/v4l2_capture_delegate.cc » ('j') | media/capture/video/mac/video_capture_device_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/video/linux/v4l2_capture_delegate.h

diff --git a/media/capture/video/linux/v4l2_capture_delegate.h b/media/capture/video/linux/v4l2_capture_delegate.h

index d047eaf970536c976bfbc3babfc5e1c5b09edd7a..120272745c9d2d690f44497a23c873d66c221adf 100644

--- a/media/capture/video/linux/v4l2_capture_delegate.h

+++ b/media/capture/video/linux/v4l2_capture_delegate.h

@@ -44,7 +44,7 @@ class V4L2CaptureDelegate final

static std::list<uint32_t> GetListOfUsableFourCcs(bool prefer_mjpeg);

V4L2CaptureDelegate(

- const VideoCaptureDevice::Name& device_name,

+ const VideoCaptureDeviceDescriptor& device_descriptor,

const scoped_refptr<base::SingleThreadTaskRunner>& v4l2_task_runner,

int power_line_frequency);

@@ -71,7 +71,7 @@ class V4L2CaptureDelegate final

const std::string& reason);

const scoped_refptr<base::SingleThreadTaskRunner> v4l2_task_runner_;

- const VideoCaptureDevice::Name device_name_;

+ const VideoCaptureDeviceDescriptor device_descriptor_;

const int power_line_frequency_;

// The following members are only known on AllocateAndStart().