Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: media/capture/video/fake_video_capture_device_factory.h

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactoring of VideoCaptureDeviceFactory interface Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/fake_video_capture_device_factory.h
diff --git a/media/capture/video/fake_video_capture_device_factory.h b/media/capture/video/fake_video_capture_device_factory.h
index 6f67c811b9053daebdb0e6070374beb99415fee5..68d6b854352b6e4d9cfda218120c108ec5e87141 100644
--- a/media/capture/video/fake_video_capture_device_factory.h
+++ b/media/capture/video/fake_video_capture_device_factory.h
@@ -21,11 +21,11 @@ class CAPTURE_EXPORT FakeVideoCaptureDeviceFactory
~FakeVideoCaptureDeviceFactory() override {}
std::unique_ptr<VideoCaptureDevice> Create(
- const VideoCaptureDevice::Name& device_name) override;
- void GetDeviceNames(VideoCaptureDevice::Names* device_names) override;
- void GetDeviceSupportedFormats(
- const VideoCaptureDevice::Name& device,
- VideoCaptureFormats* supported_formats) override;
+ const VideoCaptureDeviceDescriptor& device_descriptor) override;
+ void GetDeviceDescriptors(
+ VideoCaptureDeviceDescriptors* device_descriptors) override;
+ void GetDeviceInfo(const VideoCaptureDeviceDescriptor& device_descriptor,
+ VideoCaptureDeviceInfo* device_info) override;
void set_number_of_devices(int number_of_devices) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -39,6 +39,10 @@ class CAPTURE_EXPORT FakeVideoCaptureDeviceFactory
private:
void parse_command_line();
+ void GetDeviceSupportedFormats(
+ const VideoCaptureDeviceDescriptor& device_descriptor,
+ VideoCaptureFormats* supported_formats);
+
int number_of_devices_;
FakeVideoCaptureDevice::BufferOwnership fake_vcd_ownership_;
float frame_rate_;

Powered by Google App Engine
This is Rietveld 408576698