Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm

Issue 2168853003: Mac Picker UI: Screen Auto Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
diff --git a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
index 45b9145e5b34ee9a289b19cbf2e34beb04e9a570..89ae3a99d5d73bb070dd55d87c3ebb72a3c58955 100644
--- a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
+++ b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
@@ -18,6 +18,7 @@
imageUID_.reset([[NSString stringWithFormat:@"%d", imageUID] retain]);
imageTitle_.reset([imageTitle retain]);
}
+ hiddenTitle_ = false;
tapted 2016/07/22 03:43:37 ObjC objects are memset to 0s, so this isn't neede
qiangchen 2016/07/22 18:33:55 Done.
return self;
}
@@ -34,6 +35,10 @@
imageTitle_.reset([imageTitle copy]);
}
+- (void)setTitleHidden:(bool)hidden {
+ hiddenTitle_ = hidden;
+}
+
#pragma mark IKImageBrowserItem
- (NSString*)imageUID {
@@ -45,6 +50,8 @@
}
- (NSString*)imageTitle {
+ if (hiddenTitle_)
tapted 2016/07/22 03:43:37 nit: return titleHidden_ ? nil : imageTitle_; (th
qiangchen 2016/07/22 18:33:55 Done.
+ return nil;
return imageTitle_.get();
}

Powered by Google App Engine
This is Rietveld 408576698