Mac Picker UI: Screen Auto Selection

chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h"
 
 #import <Quartz/Quartz.h>
 
 #include "chrome/browser/media/desktop_media_list.h"
 
 @implementation DesktopMediaPickerItem
 
 - (id)initWithSourceId:(content::DesktopMediaID)sourceID
               imageUID:(int)imageUID
             imageTitle:(NSString*)imageTitle {
   if ((self = [super init])) {
     sourceID_ = sourceID;
     imageUID_.reset([[NSString stringWithFormat:@"%d", imageUID] retain]);
     imageTitle_.reset([imageTitle retain]);
   }
+  hiddenTitle_ = false;

[tapted, 2016/07/22 03:43:37]

ObjC objects are memset to 0s, so this isn't needed (see go/objcguide)

[qiangchen, 2016/07/22 18:33:55]

Done.

   return self;
 }
 
 - (content::DesktopMediaID)sourceID {
   return sourceID_;
 }
 
 - (void)setImageRepresentation:(NSImage*)image {
   image_.reset([image retain]);
   ++imageVersion_;
 }
 
 - (void)setImageTitle:(NSString*)imageTitle {
   imageTitle_.reset([imageTitle copy]);
 }
 
+- (void)setTitleHidden:(bool)hidden {
+  hiddenTitle_ = hidden;
+}
+
 #pragma mark IKImageBrowserItem
 
 - (NSString*)imageUID {
   return imageUID_;
 }
 
 - (NSString*)imageRepresentationType {
   return IKImageBrowserNSImageRepresentationType;
 }
 
 - (NSString*)imageTitle {
+  if (hiddenTitle_)

[tapted, 2016/07/22 03:43:37]

nit: return titleHidden_ ? nil : imageTitle_;

(the .get shouldn't be needed)

[qiangchen, 2016/07/22 18:33:55]

Done.

+    return nil;
   return imageTitle_.get();
 }
 
 - (NSUInteger)imageVersion {
   return imageVersion_;
 }
 
 - (id)imageRepresentation {
   return image_.get();
 }
 
 @end  // @interface DesktopMediaPickerItem