DevTools: Fix Ctrl-Z for source color picker

DevTools: Fix Ctrl-Z for source color picker

All changes to the color text from the spectrum should count as one change
for undo/redo. Pressing Ctrl-Z should also move the cursor to the change.

R=lushnikov

Committed: https://crrev.com/1dbc4855f847958bfb52edadc932229a4c3433bf
Cr-Commit-Position: refs/heads/master@{#407054}

[flandy, 2016-07-21 17:54:39]

Please take a look

[lushnikov, 2016-07-21 17:55:39]

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
(right):

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:214:
this._textEditor.editRange(this._currentColorPosition.textRange, colorString,
"*color-text-changed");
what is "*" in the beginning? Can me remove it unless it is needed?

[flandy, 2016-07-21 18:00:53]

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
(right):

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:214:
this._textEditor.editRange(this._currentColorPosition.textRange, colorString,
"*color-text-changed");
On 2016/07/21 17:55:39, lushnikov wrote:
> what is "*" in the beginning? Can me remove it unless it is needed?

The star is necessary as it is used by CodeMirror to determine that the
selection history event should be merged with the previous one. See "origin"
under setSelection https://codemirror.net/doc/manual.html#api_selection

[flandy, 2016-07-21 20:01:51]

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
(right):

https://codereview.chromium.org/2168713004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:214:
this._textEditor.editRange(this._currentColorPosition.textRange, colorString,
"*color-text-changed");
On 2016/07/21 18:00:52, flandy wrote:
> On 2016/07/21 17:55:39, lushnikov wrote:
> > what is "*" in the beginning? Can me remove it unless it is needed?
> 
> The star is necessary as it is used by CodeMirror to determine that the
> selection history event should be merged with the previous one. See "origin"
> under setSelection https://codemirror.net/doc/manual.html#api_selection

*change history event

[lushnikov, 2016-07-21 20:49:53]

got it, thanks

[lushnikov, 2016-07-21 20:50:02]

lgtm

[flandy, 2016-07-21 21:28:28]

The CQ bit was checked by flandy@google.com

[commit-bot: I haz the power, 2016-07-21 21:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 01:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:41:56]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[flandy, 2016-07-22 02:43:24]

The CQ bit was checked by flandy@google.com

[commit-bot: I haz the power, 2016-07-22 02:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:58:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 04:02:08]

Description was changed from

==========
DevTools: Fix Ctrl-Z for source color picker

All changes to the color text from the spectrum should count as one change
for undo/redo. Pressing Ctrl-Z should also move the cursor to the change.

R=lushnikov
==========

to

==========
DevTools: Fix Ctrl-Z for source color picker

All changes to the color text from the spectrum should count as one change
for undo/redo. Pressing Ctrl-Z should also move the cursor to the change.

R=lushnikov

Committed: https://crrev.com/1dbc4855f847958bfb52edadc932229a4c3433bf
Cr-Commit-Position: refs/heads/master@{#407054}
==========

[commit-bot: I haz the power, 2016-07-22 04:02:09]

Patchset 1 (id:??) landed as
https://crrev.com/1dbc4855f847958bfb52edadc932229a4c3433bf
Cr-Commit-Position: refs/heads/master@{#407054}