Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171003002: DevTools: Allow ESC for source color picker (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow ESC for source color picker When escape is pressed to hide the spectrum, use commitEdit to return to the original color text. R=lushnikov Committed: https://crrev.com/ce3b902a7a0b6c1cc0d591f9a259daa558e0504c Cr-Commit-Position: refs/heads/master@{#407177}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo instead of editRange #

Patch Set 3 : Undo if a change occurred #

Total comments: 4

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js View 1 2 3 3 chunks +14 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 2173913002 Patch 1

Messages

Total messages: 11 (3 generated)
flandy
Please take a look
4 years, 5 months ago (2016-07-21 21:44:40 UTC) #1
lushnikov
https://codereview.chromium.org/2171003002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js (right): https://codereview.chromium.org/2171003002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js#newcode227 third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:227: this._textEditor.editRange(this._currentColorPosition.textRange, this._originalColorText); will the undo stack make sense in ...
4 years, 5 months ago (2016-07-21 22:58:35 UTC) #2
flandy
Please take another look https://codereview.chromium.org/2171003002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js (right): https://codereview.chromium.org/2171003002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js#newcode227 third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:227: this._textEditor.editRange(this._currentColorPosition.textRange, this._originalColorText); On 2016/07/21 22:58:35, ...
4 years, 5 months ago (2016-07-22 00:17:11 UTC) #3
lushnikov
lgtm, thanks https://codereview.chromium.org/2171003002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js (right): https://codereview.chromium.org/2171003002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js#newcode212 third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:212: this._spectrumChangeOccurred = true; this._hadSpectrumChange = true; https://codereview.chromium.org/2171003002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js#newcode232 ...
4 years, 5 months ago (2016-07-22 04:58:17 UTC) #4
flandy
https://codereview.chromium.org/2171003002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js (right): https://codereview.chromium.org/2171003002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js#newcode212 third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js:212: this._spectrumChangeOccurred = true; On 2016/07/22 04:58:17, lushnikov wrote: > ...
4 years, 5 months ago (2016-07-22 15:56:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171003002/60001
4 years, 5 months ago (2016-07-22 15:56:39 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-22 17:01:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:02:35 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ce3b902a7a0b6c1cc0d591f9a259daa558e0504c
Cr-Commit-Position: refs/heads/master@{#407177}

Powered by Google App Engine
This is Rietveld 408576698