Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2168693002: cc: Add OverlayStrategyFullscreen strategy. (Closed)

Created:
4 years, 5 months ago by Daniele Castagna
Modified:
4 years, 5 months ago
Reviewers:
reveman, ccameron
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add OverlayStrategyFullscreen strategy. Add an overlay strategy that promotes a single quad to an overlay iff the buffer that backs the quad can be directly used as main framebuffer. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/ea959b13aa7d8186bb3936982469a6589361e646 Cr-Commit-Position: refs/heads/master@{#406676}

Patch Set 1 #

Patch Set 2 : Set deps. Don't enable strategy by default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -3 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/overlay_candidate.cc View 1 chunk +3 lines, -1 line 0 comments Download
A cc/output/overlay_strategy_fullscreen.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A cc/output/overlay_strategy_fullscreen.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 6 chunks +104 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
Daniele Castagna
4 years, 5 months ago (2016-07-20 19:42:18 UTC) #9
Daniele Castagna
4 years, 5 months ago (2016-07-20 19:42:18 UTC) #10
reveman
lgtm
4 years, 5 months ago (2016-07-20 21:00:39 UTC) #13
ccameron
lgtm
4 years, 5 months ago (2016-07-20 21:20:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168693002/20001
4 years, 5 months ago (2016-07-20 21:32:50 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 21:39:12 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:40:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea959b13aa7d8186bb3936982469a6589361e646
Cr-Commit-Position: refs/heads/master@{#406676}

Powered by Google App Engine
This is Rietveld 408576698