Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2161363003: Overlay tests: make fullscreen quads actually fullscreen. (Closed)

Created:
4 years, 5 months ago by Daniele Castagna
Modified:
4 years, 5 months ago
Reviewers:
ccameron
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Overlay tests: make fullscreen quads actually fullscreen. crrev.com/1304303002 changed the display size used in overlay_unittests. The quad size used in CreateFullscreen* utility functions didn't change, thus the fullscreen quads created for testing are not fullscreen. This CL fixes that. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/66837dabcc3ada03e7ac803d9b4fecf65bb634db Cr-Commit-Position: refs/heads/master@{#406672}

Patch Set 1 #

Patch Set 2 : CreateFullscreenOpaqueQuad use pass->output_rect. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M cc/output/overlay_unittest.cc View 1 5 chunks +9 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Daniele Castagna
4 years, 5 months ago (2016-07-20 19:42:08 UTC) #5
ccameron
lgtm
4 years, 5 months ago (2016-07-20 21:17:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161363003/20001
4 years, 5 months ago (2016-07-20 21:22:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 21:27:57 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:30:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66837dabcc3ada03e7ac803d9b4fecf65bb634db
Cr-Commit-Position: refs/heads/master@{#406672}

Powered by Google App Engine
This is Rietveld 408576698