Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2168523003: Append variation headers when fetching snippets. (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Append variation headers when fetching snippets. Since we are directly using URLFetcher, this is not done automatically. In order to propagate experiments to Google servers, this call needs to be done manually. Snippets are not enabled for incognito NTPs, so we pass false for |incognito|. BUG=629493 Review-Url: https://codereview.chromium.org/2164593002 Cr-Commit-Position: refs/heads/master@{#406269} (cherry picked from commit 630a991e73d67ae1162d9b64e22308f9c9df29ba) Committed: https://chromium.googlesource.com/chromium/src/+/fa48aa6bb99092a7e4d5f1ca6922f8d54086c72e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/ntp_snippets.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 5 months ago (2016-07-20 12:11:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa48aa6bb99092a7e4d5f1ca6922f8d54086c72e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698