Append variation headers when fetching snippets.

Append variation headers when fetching snippets.

Since we are directly using URLFetcher, this is not done automatically.
In order to propagate experiments to Google servers, this call needs to
be done manually.

Snippets are not enabled for incognito NTPs, so we pass false for
|incognito|.

BUG=629493
Committed: https://crrev.com/630a991e73d67ae1162d9b64e22308f9c9df29ba
Cr-Commit-Position: refs/heads/master@{#406269}

[sfiera, 2016-07-19 13:34:27]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-07-19 13:39:54]

lgtm

https://codereview.chromium.org/2164593002/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.cc (right):

https://codereview.chromium.org/2164593002/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.cc:339:
variations::AppendVariationHeaders(url, false, false, &headers);
nit: Maybe add a comment saying what this is for, and what the "false"s mean?

[sfiera, 2016-07-19 13:46:52]

https://codereview.chromium.org/2164593002/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.cc (right):

https://codereview.chromium.org/2164593002/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.cc:339:
variations::AppendVariationHeaders(url, false, false, &headers);
On 2016/07/19 13:39:54, Marc Treib wrote:
> nit: Maybe add a comment saying what this is for, and what the "false"s mean?

Done.

[sfiera, 2016-07-19 13:46:56]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-07-19 13:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2164593002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-07-19 13:47:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:36:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 14:38:10]

Description was changed from

==========
Append variation headers when fetching snippets.

Since we are directly using URLFetcher, this is not done automatically.
In order to propagate experiments to Google servers, this call needs to
be done manually.

Snippets are not enabled for incognito NTPs, so we pass false for
|incognito|.

BUG=629493
==========

to

==========
Append variation headers when fetching snippets.

Since we are directly using URLFetcher, this is not done automatically.
In order to propagate experiments to Google servers, this call needs to
be done manually.

Snippets are not enabled for incognito NTPs, so we pass false for
|incognito|.

BUG=629493

Committed: https://crrev.com/630a991e73d67ae1162d9b64e22308f9c9df29ba
Cr-Commit-Position: refs/heads/master@{#406269}
==========

[commit-bot: I haz the power, 2016-07-19 14:38:10]

Patchset 3 (id:??) landed as
https://crrev.com/630a991e73d67ae1162d9b64e22308f9c9df29ba
Cr-Commit-Position: refs/heads/master@{#406269}