Deprecate SkDevice::accessBitmap method

Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

Calved off: https://codereview.chromium.org/2163323002/ (Add desired width & height to drawContext (as opposed to using the width & height of the RT))

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003

Committed: https://skia.googlesource.com/skia/+/1f3923e4e5bf9afb9e52a15ced30e3854af73f7b

[robertphillips, 2016-07-20 16:04:00]

Description was changed from

==========
Deprecate SkDevice::accessBitmap method
==========

to

==========
Deprecate SkDevice::accessBitmap method
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

[robertphillips, 2016-07-20 16:06:17]

Description was changed from

==========
Deprecate SkDevice::accessBitmap method
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

to

==========
Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add
SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

[robertphillips, 2016-07-20 16:06:17]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2016-07-20 18:09:05]

Description was changed from

==========
Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add
SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

to

==========
Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add
SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

Calved off: https://codereview.chromium.org/2163323002/ (Add desired width &
height to drawContext (as opposed to using the width & height of the RT))

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

[robertphillips, 2016-07-21 12:37:17]

Patchset #4 (id:60001) has been deleted

[robertphillips, 2016-07-21 12:37:26]

Patchset #3 (id:40001) has been deleted

[robertphillips, 2016-07-21 13:02:12]

Patchset #3 (id:80001) has been deleted

[robertphillips, 2016-07-21 13:07:40]

Patchset #3 (id:100001) has been deleted

[robertphillips, 2016-07-21 13:25:42]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:46:47]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-07-21 14:13:59]

lgtm

https://codereview.chromium.org/2168483003/diff/120001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/2168483003/diff/120001/src/gpu/SkGpuDevice.h#...
src/gpu/SkGpuDevice.h:85: SkImageInfo info =
fRenderTarget->surfacePriv().info(at).makeWH(fSize.fWidth,
We could land this right-away, on its own, correct?

[robertphillips, 2016-07-21 14:16:51]

https://codereview.chromium.org/2168483003/diff/120001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/2168483003/diff/120001/src/gpu/SkGpuDevice.h#...
src/gpu/SkGpuDevice.h:85: SkImageInfo info =
fRenderTarget->surfacePriv().info(at).makeWH(fSize.fWidth,
On 2016/07/21 14:13:59, reed1 wrote:
> We could land this right-away, on its own, correct?

Acknowledged.

[robertphillips, 2016-07-21 14:16:56]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-21 14:17:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:17:56]

Description was changed from

==========
Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add
SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

Calved off: https://codereview.chromium.org/2163323002/ (Add desired width &
height to drawContext (as opposed to using the width & height of the RT))

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003
==========

to

==========
Deprecate SkDevice::accessBitmap method

Relies on https://codereview.chromium.org/2162423003/ (Add
SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

Calved off: https://codereview.chromium.org/2163323002/ (Add desired width &
height to drawContext (as opposed to using the width & height of the RT))

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003

Committed:
https://skia.googlesource.com/skia/+/1f3923e4e5bf9afb9e52a15ced30e3854af73f7b
==========

[commit-bot: I haz the power, 2016-07-21 14:17:57]

Committed patchset #3 (id:120001) as
https://skia.googlesource.com/skia/+/1f3923e4e5bf9afb9e52a15ced30e3854af73f7b