src/image/SkSurface_Gpu.cpp - Issue 2168483003: Deprecate SkDevice::accessBitmap method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkSurface_Gpu.cpp

Issue 2168483003: Deprecate SkDevice::accessBitmap method (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkSurface_Gpu.cpp

diff --git a/src/image/SkSurface_Gpu.cpp b/src/image/SkSurface_Gpu.cpp

index fa3781476fb4c41d802c4183de26868aa13f4184..8d5601d01c612bcf287818a3727612b7d4d7c79c 100644

--- a/src/image/SkSurface_Gpu.cpp

+++ b/src/image/SkSurface_Gpu.cpp

@@ -34,8 +34,6 @@ static GrRenderTarget* prepare_rt_for_external_access(SkSurface_Gpu* surface,

case SkSurface::kDiscardWrite_BackendHandleAccess:

// for now we don't special-case on Discard, but we may in the future.

surface->notifyContentWillChange(SkSurface::kRetain_ContentChangeMode);

- // legacy: need to dirty the bitmap's genID in our device (curse it)

- surface->getDevice()->accessBitmap(false).notifyPixelsChanged();

break;

}