Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2168383003:
Hack to fix settings-checkbox mixin for 1.6.0 (Closed)
|
Created:
4 years, 5 months ago by michaelpg Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@Polymer160 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHack to fix settings-checkbox mixin for 1.6.0
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7
Cr-Commit-Position: refs/heads/master@{#407347}
Patch Set 1 #
Total comments: 3
Patch Set 2 : no dependency #
Dependent Patchsets: Messages
Total messages: 17 (7 generated)
Description was changed from ========== Hack to fix settings-checkbox mixin for 1.6.0 BUG= ========== to ========== Hack to fix settings-checkbox mixin for 1.6.0 BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_checkbox.html (right): https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_checkbox.html:24: /* HACK(michaelpg): Inform Polymer that this mixin can set "display". */ why does this need a #nonexistent, and not just be the default style, i.e. :host { --settings-secondary-unchecked: { display: block; }; }
https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_checkbox.html (right): https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_checkbox.html:24: /* HACK(michaelpg): Inform Polymer that this mixin can set "display". */ On 2016/07/23 00:12:29, Dan Beam wrote: > why does this need a #nonexistent, and not just be the default style, i.e. > > :host { > --settings-secondary-unchecked: { > display: block; > }; > } or even better, display: initial; [1] https://developer.mozilla.org/en-US/docs/Web/CSS/initial
https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_checkbox.html (right): https://codereview.chromium.org/2168383003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_checkbox.html:24: /* HACK(michaelpg): Inform Polymer that this mixin can set "display". */ On 2016/07/23 00:12:29, Dan Beam wrote: > why does this need a #nonexistent, and not just be the default style, i.e. > > :host { > --settings-secondary-unchecked: { > display: block; > }; > } That would override the mixin, and the checkbox would always be display: block. We don't want to actually *set* the mixin; this is just a hack that tells Polymer to let "display" work. The bug is, basically, that Polymer only shims properties in a mixin **that are included in the mixin in the first element that references the mixin**.
well that's f*cking crazy lgtm
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2168383003/#ps20001 (title: "no dependency")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Hack to fix settings-checkbox mixin for 1.6.0 BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Hack to fix settings-checkbox mixin for 1.6.0 BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7 Cr-Commit-Position: refs/heads/master@{#407347} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7 Cr-Commit-Position: refs/heads/master@{#407347}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2179053002/ by michaelpg@chromium.org. The reason for reverting is: Not required if we disable useNativeCSSProperties for 1.6.0.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
