Issue 216833002: DevTools: only notify enabled presentation modes upon timeline start/end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216833002: DevTools: only notify enabled presentation modes upon timeline start/end. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
pan deng, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: only notify enabled presentation modes upon timeline start/end. R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170334

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
	M	Source/devtools/front_end/TimelinePanel.js	View		4 chunks	+16 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/216833002/1

6 years, 9 months ago (2014-03-28 11:19:10 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-28 11:29:06 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg

6 years, 9 months ago (2014-03-28 11:29:06 UTC) #6

pfeldman

6 years, 9 months ago (2014-03-28 15:13:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r170334 (presubmit successful).

Expand Messages | Collapse Messages