Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 216833002: DevTools: only notify enabled presentation modes upon timeline start/end. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index 1f6457db3eb8691756510c60dc493542ea1b4fdc..f399c775a7b50749360a22c6212b7b9ebda32dec 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -79,6 +79,16 @@ WebInspector.TimelinePanel = function()
this._model.addFilter(this._durationFilter);
this._model.addFilter(this._textFilter);
+ this._presentationModes = [
+ WebInspector.TimelinePanel.Mode.Events,
+ WebInspector.TimelinePanel.Mode.Frames,
+ WebInspector.TimelinePanel.Mode.Memory
+ ];
+ if (WebInspector.experimentsSettings.timelineFlameChart.isEnabled())
+ this._presentationModes.push(WebInspector.TimelinePanel.Mode.FlameChart);
+ if (Capabilities.canProfilePower)
+ this._presentationModes.push(WebInspector.TimelinePanel.Mode.Power);
+
this._presentationModeSetting = WebInspector.settings.createSetting("timelineOverviewMode", WebInspector.TimelinePanel.Mode.Events);
this._createStatusBarItems();
@@ -294,10 +304,8 @@ WebInspector.TimelinePanel.prototype = {
var topPaneSidebarTree = new TreeOutline(overviewTreeElement);
this._overviewItems = {};
- for (var mode in WebInspector.TimelinePanel.Mode) {
- if (mode === WebInspector.TimelinePanel.Mode.FlameChart && !WebInspector.experimentsSettings.timelineFlameChart.isEnabled() ||
- mode === WebInspector.TimelinePanel.Mode.Power && !Capabilities.canProfilePower)
- continue;
+ for (var i = 0; i < this._presentationModes.length; ++i) {
+ var mode = this._presentationModes[i];
this._overviewItems[mode] = new WebInspector.SidebarTreeElement("timeline-overview-sidebar-" + mode.toLowerCase(), WebInspector.UIString(mode));
var item = this._overviewItems[mode];
item.onselect = this._onModeChanged.bind(this, mode);
@@ -558,8 +566,8 @@ WebInspector.TimelinePanel.prototype = {
{
this._userInitiatedRecording = userInitiated;
this._model.startRecording();
- for (var mode in WebInspector.TimelinePanel.Mode)
- this._viewsForMode(mode).overviewView.timelineStarted();
+ for (var i = 0; i < this._presentationModes.length; ++i)
+ this._viewsForMode(this._presentationModes[i]).overviewView.timelineStarted();
if (userInitiated)
WebInspector.userMetrics.TimelineStarted.record();
@@ -569,8 +577,8 @@ WebInspector.TimelinePanel.prototype = {
{
this._userInitiatedRecording = false;
this._model.stopRecording();
- for (var mode in WebInspector.TimelinePanel.Mode)
- this._viewsForMode(mode).overviewView.timelineStopped();
+ for (var i = 0; i < this._presentationModes.length; ++i)
+ this._viewsForMode(this._presentationModes[i]).overviewView.timelineStopped();
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698