third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js

index 1d0373d15aa7972728638a074a871e2b03bf580e..801d1d48cd1359981a34d0dfba7a14043e037ee0 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js

@@ -39,8 +39,11 @@ WebInspector.ApplicationCacheModel = function(target)

this._agent = target.applicationCacheAgent();

this._agent.enable();

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameNavigated, this._frameNavigated, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, this._frameDetached, this);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);

pfeldman 2016/07/22 17:33:47 There should be no AppCacheModel when there is no

eostroukhov-old 2016/07/25 19:36:10 Done.

+ if (resourceTreeModel) {

dgozman 2016/07/22 17:19:43 This model doesn't work without frames at all.

eostroukhov-old 2016/07/25 19:36:10 Done.

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameNavigated, this._frameNavigated, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, this._frameDetached, this);

+ }

this._statuses = {};

this._manifestURLsByFrame = {};