[DevTools] Explicitly require ResourceTreeModel

third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
index 5a5736d4dea08dcd495de8d828667203a23539a6..68da74b384b73f6d3510855fc232f3e41a2e62f8 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
@@ -716,9 +716,10 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {
         if (!this._tracingModel)
             return;
         this._tracingModel.tracingComplete();
-        var resourceTreeModel = this._target.resourceTreeModel;
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);

[pfeldman, 2016/07/22 17:33:47]

1) WebInspector.NetworkPanel.FilmStripRecorder should only exist for targets
with resource tree. You should pass it in the constructor along with the target.
This is worth a separate CL.

2) We should untangle UI capability that reloads the page from resource tree
model and block it on that level.

[eostroukhov-old, 2016/07/25 19:36:10]

1) Ack, but not addressing here.
2) Routed through the target manager, as per dgozman suggestion below.

         this._target = null;
-        setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
+        if (resourceTreeModel)
+            setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
         this._callback(new WebInspector.FilmStripModel(this._tracingModel, this._timeCalculator.minimumBoundary() * 1000));
         delete this._callback;
     },
@@ -770,7 +771,9 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {
             return;
 
         this._target.tracingManager.stop();
-        this._target.resourceTreeModel.suspendReload();
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
+        if (resourceTreeModel)
+            resourceTreeModel.suspendReload();

[dgozman, 2016/07/22 17:19:43]

Let's proxy suspendReload and resumeReload through TargetManager (as we do with
TargetManager.reloadPage).

[eostroukhov-old, 2016/07/25 19:36:10]

Done - both for the supend and resume.

         this._callback = callback;
         this._filmStripView.setStatusText(WebInspector.UIString("Fetching frames..."));
     }