Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2168263002: GN: Don't complain about dart_runtime_mode == "profile" + dart_debug (AOT with asserts). (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Don't complain about dart_runtime_mode == "profile" + dart_debug (AOT with asserts). R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8fef08717fe9c4af48cc9666761fe68996bffd2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M runtime/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-21 23:06:56 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-22 13:34:01 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-22 16:58:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8fef08717fe9c4af48cc9666761fe68996bffd2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698