Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: runtime/BUILD.gn

Issue 2168263002: GN: Don't complain about dart_runtime_mode == "profile" + dart_debug (AOT with asserts). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 # TODO(zra): These build arguments should likely be moved to a gni file that is 5 # TODO(zra): These build arguments should likely be moved to a gni file that is
6 # included in BUILD.gn files that care about the values of the flags. For now, 6 # included in BUILD.gn files that care about the values of the flags. For now,
7 # since the GN build only happens as part of a Mojo build there is no need for 7 # since the GN build only happens as part of a Mojo build there is no need for
8 # the indirection. 8 # the indirection.
9 declare_args() { 9 declare_args() {
10 # Instead of using is_debug, we introduce a different flag for specifying a 10 # Instead of using is_debug, we introduce a different flag for specifying a
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 if (dart_runtime_mode == "release") { 70 if (dart_runtime_mode == "release") {
71 if (dart_debug) { 71 if (dart_debug) {
72 print("Debug and release mode are mutually exclusive.") 72 print("Debug and release mode are mutually exclusive.")
73 } 73 }
74 assert(!dart_debug) 74 assert(!dart_debug)
75 75
76 if (!dart_experimental_interpreter) { 76 if (!dart_experimental_interpreter) {
77 defines += ["DART_PRECOMPILED_RUNTIME"] 77 defines += ["DART_PRECOMPILED_RUNTIME"]
78 } 78 }
79 } else if (dart_runtime_mode == "profile") { 79 } else if (dart_runtime_mode == "profile") {
80 if (dart_debug) {
81 print("Debug and profile mode are mutually exclusive.")
82 }
83 assert(!dart_debug)
84
85 if (!dart_experimental_interpreter) { 80 if (!dart_experimental_interpreter) {
86 defines += ["DART_PRECOMPILED_RUNTIME"] 81 defines += ["DART_PRECOMPILED_RUNTIME"]
87 } 82 }
88 } 83 }
89 } 84 }
90 85
91 # Controls DART_PRECOMPILER #define. 86 # Controls DART_PRECOMPILER #define.
92 config("dart_precompiler_config") { 87 config("dart_precompiler_config") {
93 defines = [] 88 defines = []
94 defines += ["DART_PRECOMPILER"] 89 defines += ["DART_PRECOMPILER"]
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 "vm:libdart_lib_nosnapshot", 218 "vm:libdart_lib_nosnapshot",
224 "vm:libdart_lib", 219 "vm:libdart_lib",
225 "vm:libdart_vm", 220 "vm:libdart_vm",
226 "vm:libdart_platform", 221 "vm:libdart_platform",
227 "third_party/double-conversion/src:libdouble_conversion", 222 "third_party/double-conversion/src:libdouble_conversion",
228 ] 223 ]
229 sources = [ 224 sources = [
230 "vm/libdart_dependency_helper.cc", 225 "vm/libdart_dependency_helper.cc",
231 ] 226 ]
232 } 227 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698