Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3026)

Unified Diff: chrome/browser/metrics/metrics_memory_details.cc

Issue 2168233002: Un-obsolete Memory.{Browser,Renderer} metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_memory_details.cc
diff --git a/chrome/browser/metrics/metrics_memory_details.cc b/chrome/browser/metrics/metrics_memory_details.cc
index be35170b9c0706aed584407d57df7b9ff5b541ad..9f3ab3fd1ac879f363eea3c9b2d7f3cfa595aafc 100644
--- a/chrome/browser/metrics/metrics_memory_details.cc
+++ b/chrome/browser/metrics/metrics_memory_details.cc
@@ -89,6 +89,8 @@ void MetricsMemoryDetails::UpdateHistograms() {
aggregate_memory += sample;
switch (browser.processes[index].process_type) {
case content::PROCESS_TYPE_BROWSER:
+ // TODO(rkaplow): Remove later. This metric is capped at .5GB.
Ilya Sherman 2016/07/21 22:25:53 nit: Please provide a target milestone, probably "
bashi 2016/07/21 22:29:02 Yes, but I don't know a target milestone. rkaplow@
rkaplow 2016/07/25 18:52:05 You can actually remove the actual recording of th
bashi 2016/07/25 23:43:44 Done.
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Browser", sample);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Browser.Large2", sample / 1024);
continue;
case content::PROCESS_TYPE_RENDERER: {
@@ -108,6 +110,8 @@ void MetricsMemoryDetails::UpdateHistograms() {
continue;
case ProcessMemoryInformation::RENDERER_NORMAL:
default:
+ // TODO(rkaplow): Remove later. This metric is capped at .5GB.
Ilya Sherman 2016/07/21 22:25:53 Ditto.
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer", sample);
// TODO(erikkay): Should we bother splitting out the other subtypes?
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Renderer.Large2",
sample / 1024);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698