Chromium Code Reviews| Index: chrome/browser/metrics/metrics_memory_details.cc |
| diff --git a/chrome/browser/metrics/metrics_memory_details.cc b/chrome/browser/metrics/metrics_memory_details.cc |
| index be35170b9c0706aed584407d57df7b9ff5b541ad..9f3ab3fd1ac879f363eea3c9b2d7f3cfa595aafc 100644 |
| --- a/chrome/browser/metrics/metrics_memory_details.cc |
| +++ b/chrome/browser/metrics/metrics_memory_details.cc |
| @@ -89,6 +89,8 @@ void MetricsMemoryDetails::UpdateHistograms() { |
| aggregate_memory += sample; |
| switch (browser.processes[index].process_type) { |
| case content::PROCESS_TYPE_BROWSER: |
| + // TODO(rkaplow): Remove later. This metric is capped at .5GB. |
|
Ilya Sherman
2016/07/21 22:25:53
nit: Please provide a target milestone, probably "
bashi
2016/07/21 22:29:02
Yes, but I don't know a target milestone. rkaplow@
rkaplow
2016/07/25 18:52:05
You can actually remove the actual recording of th
bashi
2016/07/25 23:43:44
Done.
|
| + UMA_HISTOGRAM_MEMORY_KB("Memory.Browser", sample); |
| UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Browser.Large2", sample / 1024); |
| continue; |
| case content::PROCESS_TYPE_RENDERER: { |
| @@ -108,6 +110,8 @@ void MetricsMemoryDetails::UpdateHistograms() { |
| continue; |
| case ProcessMemoryInformation::RENDERER_NORMAL: |
| default: |
| + // TODO(rkaplow): Remove later. This metric is capped at .5GB. |
|
Ilya Sherman
2016/07/21 22:25:53
Ditto.
|
| + UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer", sample); |
| // TODO(erikkay): Should we bother splitting out the other subtypes? |
| UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Renderer.Large2", |
| sample / 1024); |