Un-obsolete Memory.{Browser,Renderer} metrics

chrome/browser/metrics/metrics_memory_details.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_memory_details.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 71 matching lines @@
   int pepper_plugin_broker_count = 0;
   int renderer_count = 0;
   int other_count = 0;
   int worker_count = 0;
   int process_limit = content::RenderProcessHost::GetMaxRendererProcessCount();
   for (size_t index = 0; index < browser.processes.size(); index++) {
     int sample = static_cast<int>(browser.processes[index].working_set.priv);
     aggregate_memory += sample;
     switch (browser.processes[index].process_type) {
       case content::PROCESS_TYPE_BROWSER:
+        // TODO(rkaplow): Remove later. This metric is capped at .5GB.

[Ilya Sherman, 2016/07/21 22:25:53]

nit: Please provide a target milestone, probably "Remove after M56 is branched".

[bashi, 2016/07/21 22:29:02]

Yes, but I don't know a target milestone. rkaplow@: can you answer this?

[rkaplow, 2016/07/25 18:52:05]

You can actually remove the actual recording of the metrics. That's actually
fine, since we can just replace with the new ones. It's more just the obsolete
tag so we can access the old metrics for now.

[bashi, 2016/07/25 23:43:44]

Done.

+        UMA_HISTOGRAM_MEMORY_KB("Memory.Browser", sample);
         UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Browser.Large2", sample / 1024);
         continue;
       case content::PROCESS_TYPE_RENDERER: {
         ProcessMemoryInformation::RendererProcessType renderer_type =
             browser.processes[index].renderer_type;
         switch (renderer_type) {
           case ProcessMemoryInformation::RENDERER_EXTENSION:
             UMA_HISTOGRAM_MEMORY_KB("Memory.Extension", sample);
             extension_count++;
             continue;
           case ProcessMemoryInformation::RENDERER_CHROME:
             UMA_HISTOGRAM_MEMORY_KB("Memory.Chrome", sample);
             chrome_count++;
             continue;
           case ProcessMemoryInformation::RENDERER_UNKNOWN:
             NOTREACHED() << "Unknown renderer process type.";
             continue;
           case ProcessMemoryInformation::RENDERER_NORMAL:
           default:
+            // TODO(rkaplow): Remove later. This metric is capped at .5GB.

[Ilya Sherman, 2016/07/21 22:25:53]

Ditto.

+            UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer", sample);
             // TODO(erikkay): Should we bother splitting out the other subtypes?
             UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Renderer.Large2",
                                           sample / 1024);
             int diff;
             if (memory_growth_tracker_ &&
                 memory_growth_tracker_->UpdateSample(
                     browser.processes[index].pid, sample, &diff)) {
               if (diff < 0)
                 UMA_HISTOGRAM_MEMORY_KB("Memory.RendererShrinkIn30Min", -diff);
               else
@@ skipping 177 matching lines @@
   UMA_HISTOGRAM_CUSTOM_COUNTS("Memory.Swap.NumWrites", swap_info().num_writes,
                               1, 100000000, 100);
 
   if (swap_info().orig_data_size > 0 && swap_info().compr_data_size > 0) {
     UMA_HISTOGRAM_CUSTOM_COUNTS(
         "Memory.Swap.CompressionRatio",
         swap_info().orig_data_size / swap_info().compr_data_size, 1, 20, 20);
   }
 }
 #endif  // defined(OS_CHROMEOS)