tools/metrics/histograms/histograms.xml - Issue 2168233002: Un-obsolete Memory.{Browser,Renderer} metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2168233002: Un-obsolete Memory.{Browser,Renderer} metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 55e8aab6212052849df22413f478f9b01d909f7b..fd254d9c34ee25be550c938eb2f9b79265e83825 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -23352,13 +23352,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>hajimehoshi@chromium.org</owner>

<owner>kenjibaheux@google.com</owner>

<owner>kouhei@chromium.org</owner>

- <obsolete>

- Deprecated 07/2016 and replaced with Memory.Browser.Large2.

- </obsolete>

The private working set used by the browser process. Recorded once per UMA

ping. Note the existence of Memory.Browser.Large, which doesn't have

- overflow issues.

+ overflow issues. TODO(rkaplow): This should be replaced with

+ Memory.Browser.Large2.

Ilya Sherman 2016/07/21 22:25:53 Please provide the same target milestone here and

bashi 2016/07/21 22:29:02 rkaplow@ ?

rkaplow 2016/07/25 18:52:05 Agreed with adjusting the comment here though. M54

bashi 2016/07/25 23:43:44 Done.

</summary>

</histogram>

@@ -23705,12 +23703,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>hajimehoshi@chromium.org</owner>

<owner>kenjibaheux@google.com</owner>

<owner>kouhei@chromium.org</owner>

- <obsolete>

- Deprecated 07/2016 and replaced with Memory.Renderer.Large2.

- </obsolete>

The private working set used by each renderer process. Each renderer

- process provides one sample. Recorded once per UMA ping.

+ process provides one sample. Recorded once per UMA ping. TODO(rkaplow):

+ This should be replaced with Memory.Renderer.Large2.

</summary>

</histogram>