Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 216823002: [Android WebView] Use container view's Context instead of target app's (Closed)

Created:
6 years, 9 months ago by mnaganov (inactive)
Modified:
6 years, 9 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Use container view's Context instead of target app's A follow up to https://codereview.chromium.org/214543009 where boliu@ noticed that we are using getInstrumentation().getTargetContext() in AwSettingsTest instead of simply getting the context of the container view. This change required some overhaul of testing classes as they didn't have access to the container view. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -134 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 60 chunks +142 lines, -134 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnaganov (inactive)
Marcin, PTAL! The change is almost mechanical, should be easy to review.
6 years, 9 months ago (2014-03-28 10:42:49 UTC) #1
mkosiba (inactive)
Thanks! LGTM
6 years, 9 months ago (2014-03-28 13:44:23 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 9 months ago (2014-03-28 13:48:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/216823002/1
6 years, 9 months ago (2014-03-28 13:50:28 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:30:05 UTC) #5
Message was sent while issue was closed.
Change committed as 260210

Powered by Google App Engine
This is Rietveld 408576698