[Android WebView] Fix AwSettingsTest.testLayoutAlgorithmWithTwoViews for wide screens

[Android WebView] Fix AwSettingsTest.testLayoutAlgorithmWithTwoViews for wide screens

The font multiplication factor used by the autosizing algorithm depends on the
ratio of the layout width to screen width. As the test was using the default
layout width of 980px, the factor was too small for tablets in landscape mode.

This fix makes the test to set layout and page width depending on the screen
width.

BUG=356960
R=skobes@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260108

[boliu, 2014-03-27 18:15:41]

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:942:
DeviceDisplayInfo.create(getInstrumentation().getTargetContext());
Can we dig into the view context here on the UI thread, instead of using the
target *application* context?

(There's a rant somewhere in my head about DeviceDisplayInfo calling
getApplicationContext...)

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:944:
int pageWidth = (int) (displayWidth * 2.5f); // Use 2.5 as autosizing layout
tests do.
These are in the "css pixels assuming the page zoom is 1x" unit right? Is there
a proper name for them? Maybe either leave a comment or modify the var name to
reflect that?

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:950:
"body { width: " + pageWidth + "px; margin: 0; overflow-y: hidden; }" +
I am really not qualified to review this bit...maybe get Ben to do it?

[skobes, 2014-03-27 20:35:45]

lgtm

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:944:
int pageWidth = (int) (displayWidth * 2.5f); // Use 2.5 as autosizing layout
tests do.
On 2014/03/27 18:15:41, boliu wrote:
> These are in the "css pixels assuming the page zoom is 1x" unit right? Is
there
> a proper name for them? Maybe either leave a comment or modify the var name to
> reflect that?

In the autosizing code we call this the "layout width".  The unit is just css
pixels, which are independent of page zoom.

[mnaganov (inactive), 2014-03-28 08:44:02]

Thanks, guys!

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:942:
DeviceDisplayInfo.create(getInstrumentation().getTargetContext());
On 2014/03/27 18:15:41, boliu wrote:
> Can we dig into the view context here on the UI thread, instead of using the
> target *application* context?
> 
> (There's a rant somewhere in my head about DeviceDisplayInfo calling
> getApplicationContext...)

Good idea. I'll do that in a separate change because for these "TwoViews" tests
I'm not saving a reference to the view that is used as a container.

https://codereview.chromium.org/214543009/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:944:
int pageWidth = (int) (displayWidth * 2.5f); // Use 2.5 as autosizing layout
tests do.
On 2014/03/27 20:35:45, skobes wrote:
> On 2014/03/27 18:15:41, boliu wrote:
> > These are in the "css pixels assuming the page zoom is 1x" unit right? Is
> there
> > a proper name for them? Maybe either leave a comment or modify the var name
to
> > reflect that?
> 
> In the autosizing code we call this the "layout width".  The unit is just css
> pixels, which are independent of page zoom.

Right, this is layout width. Fixed.

[mnaganov (inactive), 2014-03-28 08:44:22]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-03-28 08:44:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/214543009/1

[mnaganov (inactive), 2014-03-28 09:53:37]

The CQ bit was unchecked by mnaganov@chromium.org

[mnaganov (inactive), 2014-03-28 09:54:30]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2014-03-28 11:56:44]

Committed patchset #2 manually as r260108 (presubmit successful).