Fuchsia: Build standalone VM. Make it run "Hello, World!".

Fuchsia: Build standalone VM. Make it run "Hello, World!".

This CL adds targets to the GN build that build the standalone Dart VM
without the observatory, and with dart:io enabled but with most of the
functionality stubbed out as UNIMPLEMENTED(). It also adds a simple
eventhandler for Fuchsia for implementing Timers.

R=asiva@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/53374c3b99f0502dfbea2aaa79c59a2807a16136

[zra, 2016-07-21 20:13:20]

zra@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[Cutch, 2016-07-21 20:24:51]

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
File runtime/bin/hello_fuchsia.dart (right):

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
runtime/bin/hello_fuchsia.dart:6: print("Hello, Fuchsia!");
Why is this file being committed?

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_io.dart (right):

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_io.dart:24: bool _hasSignals = true;
This change is likely to break other embedders who set this flag from C++ code.

[zra, 2016-07-22 17:47:20]

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
File runtime/bin/hello_fuchsia.dart (right):

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
runtime/bin/hello_fuchsia.dart:6: print("Hello, Fuchsia!");
On 2016/07/21 20:24:51, Cutch wrote:
> Why is this file being committed? 

This is temporary until there is a place in the Fuchsia tree that this can go. I
have moved it somewhere else in the Dart tree that makes more sense in the
meantime.

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_io.dart (right):

https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_io.dart:24: bool _hasSignals = true;
On 2016/07/21 20:24:51, Cutch wrote:
> This change is likely to break other embedders who set this flag from C++
code.

Restored _isWindows. Added _isFuchsia.

[Cutch, 2016-07-22 17:48:17]

lgtm

[siva, 2016-07-22 19:18:22]

lgtm

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
File runtime/bin/directory_fuchsia.cc (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
runtime/bin/directory_fuchsia.cc:57: if ((written <= PATH_MAX - length_) &&
(PATH_MAX - length_)

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
runtime/bin/directory_fuchsia.cc:58: (written >= 0) &&
When would written be 0?

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_fuchsia.cc (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_fuchsia.cc:79: }
for status == ERR_BAD_STATE we seem to do nothing, Should we at least log a
message.

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_fuchsia.h (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_fuchsia.h:27: int64_t GetTimeout();
GetTimeout() const;

[abarth, 2016-07-22 19:21:13]

On 2016/07/22 at 17:47:20, zra wrote:
>
https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
> File runtime/bin/hello_fuchsia.dart (right):
> 
>
https://codereview.chromium.org/2168193002/diff/20001/runtime/bin/hello_fuchs...
> runtime/bin/hello_fuchsia.dart:6: print("Hello, Fuchsia!");
> On 2016/07/21 20:24:51, Cutch wrote:
> > Why is this file being committed? 
> 
> This is temporary until there is a place in the Fuchsia tree that this can go.
I have moved it somewhere else in the Dart tree that makes more sense in the
meantime.

We can make an "examples" directory in
https://fuchsia.googlesource.com/dart_content_handler/+/master to house this
sort of thing.

[zra, 2016-07-22 20:07:08]

Thanks!

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
File runtime/bin/directory_fuchsia.cc (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
runtime/bin/directory_fuchsia.cc:57: if ((written <= PATH_MAX - length_) &&
On 2016/07/22 19:18:22, siva wrote:
> (PATH_MAX - length_)

Done.

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/directory_f...
runtime/bin/directory_fuchsia.cc:58: (written >= 0) &&
On 2016/07/22 19:18:22, siva wrote:
> When would written be 0?

It could be zero when name is "", but that would probably be a bug, so I've
added a check for that first, and changed the condition here to >.

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_fuchsia.cc (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_fuchsia.cc:79: }
On 2016/07/22 19:18:22, siva wrote:
> for status == ERR_BAD_STATE we seem to do nothing, Should we at least log a
> message.

status should be ERR_BAD_STATE when we try to read when there are no messages
available. If status is not ERR_BAD_STATE it means there was some other error
that should be reported. I've added a comment.

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_fuchsia.h (right):

https://codereview.chromium.org/2168193002/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_fuchsia.h:27: int64_t GetTimeout();
On 2016/07/22 19:18:22, siva wrote:
> GetTimeout() const;

Done.

[zra, 2016-07-22 21:00:34]

Description was changed from

==========
Fuchsia: Build standalone VM. Make it run "Hello, World!".

This CL adds targets to the GN build that build the standalone Dart VM
without the observatory, and with dart:io enabled but with most of the
functionality stubbed out as UNIMPLEMENTED(). It also adds a simple
eventhandler for Fuchsia for implementing Timers.
==========

to

==========
Fuchsia: Build standalone VM. Make it run "Hello, World!".

This CL adds targets to the GN build that build the standalone Dart VM
without the observatory, and with dart:io enabled but with most of the
functionality stubbed out as UNIMPLEMENTED(). It also adds a simple
eventhandler for Fuchsia for implementing Timers.

R=asiva@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53374c3b99f0502dfbea2aaa79c59a2807a16136
==========

[zra, 2016-07-22 21:00:36]

Committed patchset #4 (id:60001) manually as
53374c3b99f0502dfbea2aaa79c59a2807a16136.