runtime/platform/utils_fuchsia.h - Issue 2168193002: Fuchsia: Build standalone VM. Make it run "Hello, World!".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/platform/utils_fuchsia.h

Issue 2168193002: Fuchsia: Build standalone VM. Make it run "Hello, World!". (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/platform/utils_fuchsia.h

diff --git a/runtime/platform/utils_fuchsia.h b/runtime/platform/utils_fuchsia.h

index a44fcb8b4869e17a43485bf5671cfbece9343122..0129bfeb20187d849f9c201808707b81177662fb 100644

--- a/runtime/platform/utils_fuchsia.h

+++ b/runtime/platform/utils_fuchsia.h

@@ -68,8 +68,8 @@ inline uint64_t Utils::HostToLittleEndian64(uint64_t value) {

inline char* Utils::StrError(int err, char* buffer, size_t bufsize) {

- UNIMPLEMENTED();

- return NULL;

+ snprintf(buffer, bufsize, "errno = %d", err);

+ return buffer;

}

} // namespace dart

« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | runtime/tests/vm/dart/hello_fuchsia_test.dart » ('j') | no next file with comments »