Adding keyboard shortcut BROWSE+SHIFT+N to launch 'Connectivity diag.' extension.

Adding keyboard shortcut BROWSE+SHIFT+N to launch 'Connectivity diag.' extension.

Chrome has a built in 'Connectivity Diagnostics' extension (shipped with
all versions) that performs network tests such as captive portal, dns,
firewall, google services check, local network check.

As of now, the only way to access this tool is a link in the browser when
a site fails to load.

It would be useful to have a keyboard shortcut BROWSE+SHIFT+N that launches
this extension directly when end users encounter other issues such
as sync issues, enterprise issues, cloud print issues, etc.

BUG=630310
R=sky@chromium.org
TEST=build chromium and enter BROWSE+SHIFT+N; extension launches in browser.

[yyefet, 2016-07-21 17:02:30]

Submitting keyboard shortcut CL for review, thanks!

[sky, 2016-07-21 19:30:54]

Did you run this by ux? You'll need to merge with tip of tree as I just moved
all these files (sorry). Also, run git cl format.

https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h
File ash/new_window_delegate.h (right):

https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h#n...
ash/new_window_delegate.h:43: // Invoked when the user opens Network Diag.
diag? Dialog.

[yyefet, 2016-07-21 20:14:24]

On 2016/07/21 19:30:54, sky wrote:
> Did you run this by ux? You'll need to merge with tip of tree as I just moved
> all these files (sorry). Also, run git cl format.
> 
> https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h
> File ash/new_window_delegate.h (right):
> 
>
https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h#n...
> ash/new_window_delegate.h:43: // Invoked when the user opens Network Diag.
> diag? Dialog.

Waiting for comments from UX team on crbug 630310.

Is there a specific git command to merge w/ tip of tree or should I just
re-sync?

Ran 'git cl format' with no output.

Thanks!

[sky, 2016-07-21 21:43:29]

Resync.

On Thu, Jul 21, 2016 at 1:14 PM,  <yyefet@chromium.org> wrote:
> On 2016/07/21 19:30:54, sky wrote:
>> Did you run this by ux? You'll need to merge with tip of tree as I just
>> moved
>> all these files (sorry). Also, run git cl format.
>>
>>
>> https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h
>> File ash/new_window_delegate.h (right):
>>
>>
>
https://codereview.chromium.org/2168143002/diff/1/ash/new_window_delegate.h#n...
>> ash/new_window_delegate.h:43: // Invoked when the user opens Network Diag.
>> diag? Dialog.
>
> Waiting for comments from UX team on crbug 630310.
>
> Is there a specific git command to merge w/ tip of tree or should I just
> re-sync?
>
> Ran 'git cl format' with no output.
>
> Thanks!
>
>
> https://codereview.chromium.org/2168143002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yyefet, 2016-07-23 20:28:34]

Description was changed from

==========
Adding keyboard shortcut CTRL-ALT-N to launch 'Connectivity diag.' extension.

Chrome has a built in 'Connectivity Diagnostics' extension (shipped with
all versions) that performs network tests such as captive portal, dns,
firewall, google services check, local network check.

As of now, the only way to access this tool is a link in the browser when
a site fails to load.

It would be useful to have a keyboard shortcut CTRL-ALT-N that launches
this extension directly when end users encounter other issues such
as sync issues, enterprise issues, cloud print issues, etc.

BUG=630310
R=sky@chromium.org
TEST=build chromium and enter CTRL+ALT+N; extension launches in browser.
==========

to

==========
Adding keyboard shortcut BROWSE+SHIFT+N to launch 'Connectivity diag.'
extension.

Chrome has a built in 'Connectivity Diagnostics' extension (shipped with
all versions) that performs network tests such as captive portal, dns,
firewall, google services check, local network check.

As of now, the only way to access this tool is a link in the browser when
a site fails to load.

It would be useful to have a keyboard shortcut BROWSE+SHIFT+N that launches
this extension directly when end users encounter other issues such
as sync issues, enterprise issues, cloud print issues, etc.

BUG=630310
R=sky@chromium.org
TEST=build chromium and enter BROWSE+SHIFT+N; extension launches in browser.
==========