chrome/browser/ui/ash/chrome_new_window_delegate.h - Issue 2168143002: Adding keyboard shortcut BROWSE+SHIFT+N to launch 'Connectivity diag.' extension.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ash/chrome_new_window_delegate.h

Issue 2168143002: Adding keyboard shortcut BROWSE+SHIFT+N to launch 'Connectivity diag.' extension. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed key combo to browse shift N to avoid accidents. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/test/test_shell_delegate.cc ('k') | chrome/browser/ui/ash/chrome_new_window_delegate.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_	5 #ifndef CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_

6 #define CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_	6 #define CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "ash/new_window_delegate.h"	10 #include "ash/new_window_delegate.h"

(...skipping 10 matching lines...) Expand all Loading...
21 // Overridden from ash::NewWindowDelegate:	21 // Overridden from ash::NewWindowDelegate:

22 void NewTab() override;	22 void NewTab() override;

23 void NewWindow(bool incognito) override;	23 void NewWindow(bool incognito) override;

24 void OpenFileManager() override;	24 void OpenFileManager() override;

25 void OpenCrosh() override;	25 void OpenCrosh() override;

26 void OpenGetHelp() override;	26 void OpenGetHelp() override;

27 void RestoreTab() override;	27 void RestoreTab() override;

28 void ShowKeyboardOverlay() override;	28 void ShowKeyboardOverlay() override;

29 void ShowTaskManager() override;	29 void ShowTaskManager() override;

30 void OpenFeedbackPage() override;	30 void OpenFeedbackPage() override;

	31 void OpenNetworkDiag() override;

31	32

32 private:	33 private:

33 class TabRestoreHelper;	34 class TabRestoreHelper;

34	35

35 std::unique_ptr<TabRestoreHelper> tab_restore_helper_;	36 std::unique_ptr<TabRestoreHelper> tab_restore_helper_;

36	37

37 DISALLOW_COPY_AND_ASSIGN(ChromeNewWindowDelegate);	38 DISALLOW_COPY_AND_ASSIGN(ChromeNewWindowDelegate);

38 };	39 };

39	40

40 #endif // CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_	41 #endif // CHROME_BROWSER_UI_ASH_CHROME_NEW_WINDOW_DELEGATE_H_

OLD	NEW