Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2168133003: Add the product check into shouldSkip in DisableIf (Closed)

Created:
4 years, 5 months ago by the real yoland
Modified:
4 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the product check into shouldSkip in DisableIf Committed: https://crrev.com/77c0bf9dbd4f958f26df968ba0c1908c69891d16 Cr-Commit-Position: refs/heads/master@{#406977}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
the real yoland
4 years, 5 months ago (2016-07-21 19:26:38 UTC) #2
jbudorick
lgtm
4 years, 5 months ago (2016-07-21 19:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168133003/1
4 years, 5 months ago (2016-07-21 19:29:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99819)
4 years, 5 months ago (2016-07-21 19:42:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168133003/20001
4 years, 5 months ago (2016-07-21 21:41:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 22:47:20 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:50:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77c0bf9dbd4f958f26df968ba0c1908c69891d16
Cr-Commit-Position: refs/heads/master@{#406977}

Powered by Google App Engine
This is Rietveld 408576698