Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java

Issue 2168133003: Add the product check into shouldSkip in DisableIf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java b/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
index 38eb16ada8347d3f83d324f6f1dfc95ce1563e73..ecb0c1f78e6f4886f3c6f6b777f2c3b2d865e9a7 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
@@ -28,7 +28,7 @@ public class DisableIfSkipCheck extends SkipCheck {
if (method == null) return true;
for (DisableIf.Build v : getAnnotations(method, DisableIf.Build.class)) {
- if (abi(v) && hardware(v) && sdk(v)) {
+ if (abi(v) && hardware(v) && product(v) && sdk(v)) {
if (!v.message().isEmpty()) {
Log.i(TAG, "%s is disabled: %s", testCase.toString(), v.message());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698