Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2168013002: [M53] service worker: Clean up the fetch event request if URLRequest gets cancelled. (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[M53] service worker: Clean up the fetch event request if URLRequest gets cancelled. Before this patch, an inflight fetch event would never be finished, since the request being cancelled results in the URLRequestJob being destroyed, so the the response callback is never called. Eventually the event would timeout, but this is an error state that terminates the worker. It's better to listen for the response and finish the request cleanly. BUG=616331 Review-Url: https://codereview.chromium.org/2114893002 Cr-Commit-Position: refs/heads/master@{#403632} (cherry picked from commit 9ed9574ae81390911dd582a0d5a49a4c0430eafa) Committed: https://chromium.googlesource.com/chromium/src/+/802c9e886637e00ee90de9b139c233e26f0f56af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -12 lines) Patch
M content/browser/service_worker/service_worker_fetch_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +34 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 2 chunks +68 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
falken
4 years, 5 months ago (2016-07-21 05:45:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
802c9e886637e00ee90de9b139c233e26f0f56af.

Powered by Google App Engine
This is Rietveld 408576698