Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2114893002: service worker: Clean up fetch event if URLRequest gets cancelled. (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Clean up the fetch event request if URLRequest gets cancelled. Before this patch, an inflight fetch event would never be finished, since the request being cancelled results in the URLRequestJob being destroyed, so the the response callback is never called. Eventually the event would timeout, but this is an error state that terminates the worker. It's better to listen for the response and finish the request cleanly. BUG=616331 Committed: https://crrev.com/9ed9574ae81390911dd582a0d5a49a4c0430eafa Cr-Commit-Position: refs/heads/master@{#403632}

Patch Set 1 #

Patch Set 2 : fmt #

Patch Set 3 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -12 lines) Patch
M content/browser/service_worker/service_worker_fetch_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 3 chunks +34 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 2 2 chunks +68 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
falken
horo@: PTAL
4 years, 5 months ago (2016-07-04 02:21:33 UTC) #3
horo
lgtm
4 years, 5 months ago (2016-07-04 03:19:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114893002/40001
4 years, 5 months ago (2016-07-04 03:21:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-04 03:52:20 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 03:54:00 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ed9574ae81390911dd582a0d5a49a4c0430eafa
Cr-Commit-Position: refs/heads/master@{#403632}

Powered by Google App Engine
This is Rietveld 408576698