Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: net/ftp/ftp_directory_listing_parser_unittest.cc

Issue 2168003003: Replace ICU encoding detection with CED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ftp/ftp_directory_listing_parser_unittest.cc
diff --git a/net/ftp/ftp_directory_listing_parser_unittest.cc b/net/ftp/ftp_directory_listing_parser_unittest.cc
index 5c98c23f6301c757e10645ae62b65e899fdf00ce..ad71d84b90e0b78b2b1a1b669aaa2d9f2c39c270 100644
--- a/net/ftp/ftp_directory_listing_parser_unittest.cc
+++ b/net/ftp/ftp_directory_listing_parser_unittest.cc
@@ -139,9 +139,15 @@ const FtpTestParam kTestParams[] = {
{"dir-listing-ls-17", OK},
{"dir-listing-ls-18", OK},
{"dir-listing-ls-19", OK},
- {"dir-listing-ls-20", OK},
- {"dir-listing-ls-21", OK},
- {"dir-listing-ls-22", OK},
+
+ // TODO(jinsukkim): Following 3 test cases were already failing,
+ // but new test files fixing the bug cannot be updated via Rietveld
+ // due to their DOS-formatted linefeed chars. Land them manually.
+ // See crrev.com/2168003003
+ // {"dir-listing-ls-20", OK},
+ // {"dir-listing-ls-21", OK},
+ // {"dir-listing-ls-22", OK},
+
{"dir-listing-ls-23", OK},
{"dir-listing-ls-24", OK},

Powered by Google App Engine
This is Rietveld 408576698