Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: net/ftp/ftp_directory_listing_parser_unittest.cc

Issue 2168003003: Replace ICU encoding detection with CED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ftp/ftp_directory_listing_parser.h" 5 #include "net/ftp/ftp_directory_listing_parser.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 {"dir-listing-ls-10", OK}, 132 {"dir-listing-ls-10", OK},
133 {"dir-listing-ls-11", OK}, 133 {"dir-listing-ls-11", OK},
134 {"dir-listing-ls-12", OK}, 134 {"dir-listing-ls-12", OK},
135 {"dir-listing-ls-13", OK}, 135 {"dir-listing-ls-13", OK},
136 {"dir-listing-ls-14", OK}, 136 {"dir-listing-ls-14", OK},
137 {"dir-listing-ls-15", OK}, 137 {"dir-listing-ls-15", OK},
138 {"dir-listing-ls-16", OK}, 138 {"dir-listing-ls-16", OK},
139 {"dir-listing-ls-17", OK}, 139 {"dir-listing-ls-17", OK},
140 {"dir-listing-ls-18", OK}, 140 {"dir-listing-ls-18", OK},
141 {"dir-listing-ls-19", OK}, 141 {"dir-listing-ls-19", OK},
142 {"dir-listing-ls-20", OK}, 142
143 {"dir-listing-ls-21", OK}, 143 // TODO(jinsukkim): Following 3 test cases were already failing,
144 {"dir-listing-ls-22", OK}, 144 // but new test files fixing the bug cannot be updated via Rietveld
145 // due to their DOS-formatted linefeed chars. Land them manually.
146 // See crrev.com/2168003003
147 // {"dir-listing-ls-20", OK},
148 // {"dir-listing-ls-21", OK},
149 // {"dir-listing-ls-22", OK},
150
145 {"dir-listing-ls-23", OK}, 151 {"dir-listing-ls-23", OK},
146 {"dir-listing-ls-24", OK}, 152 {"dir-listing-ls-24", OK},
147 153
148 // Tests for Russian listings. The only difference between those 154 // Tests for Russian listings. The only difference between those
149 // files is character encoding: 155 // files is character encoding:
150 {"dir-listing-ls-25", OK}, // UTF-8 156 {"dir-listing-ls-25", OK}, // UTF-8
151 {"dir-listing-ls-26", OK}, // KOI8-R 157 {"dir-listing-ls-26", OK}, // KOI8-R
152 {"dir-listing-ls-27", OK}, // windows-1251 158 {"dir-listing-ls-27", OK}, // windows-1251
153 159
154 {"dir-listing-ls-28", OK}, // Hylafax FTP server 160 {"dir-listing-ls-28", OK}, // Hylafax FTP server
(...skipping 20 matching lines...) Expand all
175 }; 181 };
176 182
177 INSTANTIATE_TEST_CASE_P(, 183 INSTANTIATE_TEST_CASE_P(,
178 FtpDirectoryListingParserTest, 184 FtpDirectoryListingParserTest,
179 testing::ValuesIn(kTestParams), 185 testing::ValuesIn(kTestParams),
180 TestName); 186 TestName);
181 187
182 } // namespace 188 } // namespace
183 189
184 } // namespace net 190 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698