dashboard/dashboard/elements/alerts-table.html - Issue 2167993002: [polymer] Fix bug where sometimes old ellipsiz(ation?) would hang around

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/elements/alerts-table.html

Issue 2167993002: [polymer] Fix bug where sometimes old ellipsiz(ation?) would hang around (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dashboard/dashboard/elements/alerts-table.html

diff --git a/dashboard/dashboard/elements/alerts-table.html b/dashboard/dashboard/elements/alerts-table.html

index 7dcd99b7742c13ccb297b6b1d9713c92aac39d25..41d8a22f6181beab96e8132b1099dc89fcb086c1 100644

--- a/dashboard/dashboard/elements/alerts-table.html

+++ b/dashboard/dashboard/elements/alerts-table.html

@@ -568,10 +568,13 @@ found in the LICENSE file.

addEllipsis: function() {

for (var i = 0; i < this.alertList.length; i++) {

+ this.setAlertList(i, 'additionalColumnValues', {});

+ }

+ for (var i = 0; i < this.alertList.length; i++) {

var alert = this.alertList[i];

if (alert.rowType == 'group-header' && alert.size > 1) {

var headerRowIndex = i;

- this.setAlertList(i, 'additionalColumnValues', {});

for (var j = i + 1; j < this.alertList.length; j++) {

var memberAlert = this.alertList[j];

if (memberAlert.rowType == 'group-member') {

« no previous file with comments | « no previous file | no next file » | no next file with comments »