Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: dashboard/dashboard/elements/alerts-table.html

Issue 2167993002: [polymer] Fix bug where sometimes old ellipsiz(ation?) would hang around (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright 2016 The Chromium Authors. All rights reserved. 3 Copyright 2016 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/components/iron-icon/iron-icon.html"> 8 <link rel="import" href="/components/iron-icon/iron-icon.html">
9 <link rel="import" href="/components/iron-icons/iron-icons.html"> 9 <link rel="import" href="/components/iron-icons/iron-icons.html">
10 <link rel="import" href="/components/paper-button/paper-button.html"> 10 <link rel="import" href="/components/paper-button/paper-button.html">
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 this.set('alertList', orderedAlertList); 561 this.set('alertList', orderedAlertList);
562 this.addEllipsis(); 562 this.addEllipsis();
563 }, 563 },
564 564
565 /** 565 /**
566 * Adds ellipsis to each column in header rows that contains different 566 * Adds ellipsis to each column in header rows that contains different
567 * values than its group member rows. 567 * values than its group member rows.
568 */ 568 */
569 addEllipsis: function() { 569 addEllipsis: function() {
570 for (var i = 0; i < this.alertList.length; i++) { 570 for (var i = 0; i < this.alertList.length; i++) {
571 this.setAlertList(i, 'additionalColumnValues', {});
572 }
573
574 for (var i = 0; i < this.alertList.length; i++) {
571 var alert = this.alertList[i]; 575 var alert = this.alertList[i];
572 if (alert.rowType == 'group-header' && alert.size > 1) { 576 if (alert.rowType == 'group-header' && alert.size > 1) {
573 var headerRowIndex = i; 577 var headerRowIndex = i;
574 this.setAlertList(i, 'additionalColumnValues', {});
575 for (var j = i + 1; j < this.alertList.length; j++) { 578 for (var j = i + 1; j < this.alertList.length; j++) {
576 var memberAlert = this.alertList[j]; 579 var memberAlert = this.alertList[j];
577 if (memberAlert.rowType == 'group-member') { 580 if (memberAlert.rowType == 'group-member') {
578 if (memberAlert.master != alert.master) { 581 if (memberAlert.master != alert.master) {
579 this.setAlertList( 582 this.setAlertList(
580 headerRowIndex, 'additionalColumnValues.master', true); 583 headerRowIndex, 'additionalColumnValues.master', true);
581 } 584 }
582 if (memberAlert.bot != alert.bot) { 585 if (memberAlert.bot != alert.bot) {
583 this.setAlertList( 586 this.setAlertList(
584 headerRowIndex, 'additionalColumnValues.bot', true); 587 headerRowIndex, 'additionalColumnValues.bot', true);
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 end: alert.end_revision 1060 end: alert.end_revision
1058 }; 1061 };
1059 1062
1060 return findRangeIntersection( 1063 return findRangeIntersection(
1061 commonRevisionRange, alertRevisionRange) != null; 1064 commonRevisionRange, alertRevisionRange) != null;
1062 } 1065 }
1063 }); 1066 });
1064 })(); 1067 })();
1065 </script> 1068 </script>
1066 </dom-module> 1069 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698