Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2167943002: [webcrypto] Update a comment to indicate that HmacImportParams.hash is required. (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Update a comment to indicate that HmacImportParams.hash is required. This changed upstream in: https://github.com/w3c/webcrypto/commit/c07a840270334e961e54b4b2ad98f37cd07888cb Committed: https://crrev.com/48bd10d7ce11607bec7015c2f85122a767845b1b Cr-Commit-Position: refs/heads/master@{#406803}

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : revert accidental upload (patchset2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
eroman
4 years, 5 months ago (2016-07-20 23:55:03 UTC) #2
Ryan Sleevi
lgtm
4 years, 5 months ago (2016-07-21 00:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167943002/1
4 years, 5 months ago (2016-07-21 05:01:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167943002/40001
4 years, 5 months ago (2016-07-21 05:11:02 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 08:15:04 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 08:16:44 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/48bd10d7ce11607bec7015c2f85122a767845b1b
Cr-Commit-Position: refs/heads/master@{#406803}

Powered by Google App Engine
This is Rietveld 408576698