Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

Issue 2167943002: [webcrypto] Update a comment to indicate that HmacImportParams.hash is required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert accidental upload (patchset2) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
diff --git a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
index 90e4b90ca2e1c25d924233760f004327242402f4..d47808eef9da19e2f4766a2f1b0a4af98592cae0 100644
--- a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
+++ b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
@@ -497,13 +497,9 @@ bool parseHash(const Dictionary& raw, WebCryptoAlgorithm& hash, ErrorContext con
// Defined by the WebCrypto spec as:
//
// dictionary HmacImportParams : Algorithm {
-// HashAlgorithmIdentifier hash;
+// required HashAlgorithmIdentifier hash;
// [EnforceRange] unsigned long length;
// };
-//
-// FIXME: http://crbug.com/438475: The current implementation differs from the
-// spec in that the "hash" parameter is required. This seems more sensible, and
-// is being proposed as a change to the spec. (https://www.w3.org/Bugs/Public/show_bug.cgi?id=27448).
bool parseHmacImportParams(const Dictionary& raw, std::unique_ptr<WebCryptoAlgorithmParams>& params, const ErrorContext& context, AlgorithmError* error)
{
WebCryptoAlgorithm hash;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698