Issue 216793008: Revert 260175 "Fixup mojo dylibs to support mojo in content"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216793008: Revert 260175 "Fixup mojo dylibs to support mojo in content" (Closed)

Created:
6 years, 9 months ago by DaveMoore

Modified:
6 years, 9 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 260175 "Fixup mojo dylibs to support mojo in content" sky is about to check something in that will interact poorly with this and it'll be easier to apply the necessary changes after that. > Fixup mojo dylibs to support mojo in content > > Second try after revert of > https://codereview.chromium.org/211503005/ > > The isolates failed because libmojo_system.dylib wasn't getting copied. > > BUG= > TBR=mark@chromium.org > > Review URL: https://codereview.chromium.org/217003003 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260181

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -77 lines)			Patch
M	trunk/src/build/common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/chrome.isolate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/chrome_dll_bundle.gypi	View	2 chunks	+1 line, -30 lines	0 comments	Download
M	trunk/src/chrome/tools/build/mac/dump_product_syms	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/content_shell.gypi	View	1 chunk	+1 line, -30 lines	0 comments	Download
M	trunk/src/mojo/mojo_public.gypi	View	3 chunks	+24 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r260181.