Issue 217003003: Fixup mojo dylibs to support mojo in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217003003: Fixup mojo dylibs to support mojo in content (Closed)

Created:
6 years, 9 months ago by DaveMoore

Modified:
6 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixup mojo dylibs to support mojo in content Second try after revert of https://codereview.chromium.org/211503005/ The isolates failed because libmojo_system.dylib wasn't getting copied. BUG= TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260175

Patch Set 1 #

Patch Set 2 : Add isolate support #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -27 lines)			Patch
M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.isolate	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_dll_bundle.gypi	View		2 chunks	+30 lines, -1 line	1 comment	Download
M	chrome/tools/build/mac/dump_product_syms	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_shell.gypi	View		1 chunk	+30 lines, -1 line	1 comment	Download
M	mojo/mojo_public.gypi	View		3 chunks	+14 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

Committed patchset #2 manually as r260175 (presubmit successful).

6 years, 9 months ago (2014-03-28 17:05:34 UTC) #2

Mark Mentovai

6 years, 8 months ago (2014-04-01 18:38:21 UTC) #3

Message was sent while issue was closed.

I’m back! LGTM, followup OK for these two comment nits.

https://codereview.chromium.org/217003003/diff/20001/chrome/chrome_dll_bundle...
File chrome/chrome_dll_bundle.gypi (right):

https://codereview.chromium.org/217003003/diff/20001/chrome/chrome_dll_bundle...
chrome/chrome_dll_bundle.gypi:171: # Copy FFmpeg binaries for audio/video
support and mojo.
Fix comment. This doesn’t handle mojo anymore.

https://codereview.chromium.org/217003003/diff/20001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/217003003/diff/20001/content/content_shell.gy...
content/content_shell.gypi:884: # Copy FFmpeg for audio/video support and mojo.
Ditto.

Expand Messages | Collapse Messages