Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 216793004: Changed strings for first-run UI. (Closed)

Created:
6 years, 9 months ago by dzhioev (left Google)
Modified:
6 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Changed strings for first-run UI. BUG=353192 TEST=manually R=nkostylev@chromium.org TBR=scheib Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dzhioev (left Google)
6 years, 9 months ago (2014-03-28 13:04:12 UTC) #1
Nikita (slow)
lgtm
6 years, 9 months ago (2014-03-28 13:05:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/216793004/1
6 years, 9 months ago (2014-03-28 13:06:13 UTC) #3
dzhioev (left Google)
The CQ bit was unchecked by dzhioev@chromium.org
6 years, 9 months ago (2014-03-28 15:59:01 UTC) #4
dzhioev (left Google)
6 years, 9 months ago (2014-03-28 16:02:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r260142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698