Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2167883002: MD Downloads: fix clear all keyboard shortcut on Mac (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix clear all keyboard shortcut on Mac BUG=630001 R=dtapuska@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657 Cr-Commit-Position: refs/heads/master@{#407246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/downloads.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Dan Beam
4 years, 5 months ago (2016-07-21 21:40:58 UTC) #2
dtapuska
On 2016/07/21 21:40:58, Dan Beam wrote: lgtm; I do wonder if we are going to ...
4 years, 5 months ago (2016-07-22 15:18:05 UTC) #3
Dan Beam
On 2016/07/22 15:18:05, dtapuska wrote: > On 2016/07/21 21:40:58, Dan Beam wrote: > > lgtm; ...
4 years, 5 months ago (2016-07-22 18:08:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167883002/1
4 years, 5 months ago (2016-07-22 18:09:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 20:24:01 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:29:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657
Cr-Commit-Position: refs/heads/master@{#407246}

Powered by Google App Engine
This is Rietveld 408576698