Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 2153323002: MD Downloads: rework "more actions" menu focus handling code (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: rework "more actions" menu focus handling code 1) Hide the menu if focus moves outside of the menu 2) Don't /always/ restore focus to the <paper-menu-button> R=tsergeant@chromium.org BUG=621842 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362 Cr-Commit-Position: refs/heads/master@{#405965}

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -20 lines) Patch
M chrome/browser/resources/md_downloads/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +26 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 2 chunks +27 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
Dan Beam
4 years, 5 months ago (2016-07-16 02:01:47 UTC) #3
tsergeant
lgtm % closure issue https://codereview.chromium.org/2153323002/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/2153323002/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode48 chrome/browser/resources/md_downloads/toolbar.js:48: closeMoreActions_: function(e) { You need ...
4 years, 5 months ago (2016-07-18 01:53:19 UTC) #8
Dan Beam
https://codereview.chromium.org/2153323002/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/2153323002/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode48 chrome/browser/resources/md_downloads/toolbar.js:48: closeMoreActions_: function(e) { On 2016/07/18 01:53:19, tsergeant wrote: > ...
4 years, 5 months ago (2016-07-18 07:09:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153323002/20001
4 years, 5 months ago (2016-07-18 07:10:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 08:08:34 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:10:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362
Cr-Commit-Position: refs/heads/master@{#405965}

Powered by Google App Engine
This is Rietveld 408576698