Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: infra/bots/assets/skp/create_and_upload.py

Issue 2167763002: Add "skp" asset (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Backpedal: Don't get rid of old SKPs yet Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/assets/skp/create.py ('k') | infra/bots/assets/skp/download.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/assets/skp/create_and_upload.py
diff --git a/infra/bots/assets/win_toolchain/create_and_upload.py b/infra/bots/assets/skp/create_and_upload.py
similarity index 71%
copy from infra/bots/assets/win_toolchain/create_and_upload.py
copy to infra/bots/assets/skp/create_and_upload.py
index d428ca4ef9df2352ea3627f1656e59fd27e6eef2..6567f80ffc35fd2b6cd547fa3c3b664b163471f0 100755
--- a/infra/bots/assets/win_toolchain/create_and_upload.py
+++ b/infra/bots/assets/skp/create_and_upload.py
@@ -19,9 +19,9 @@ import utils
def main():
parser = argparse.ArgumentParser()
+ parser.add_argument('--chrome_src_path', '-c', required=True)
+ parser.add_argument('--browser_executable', '-e', required=True)
parser.add_argument('--gsutil')
- parser.add_argument('--chrome_path')
- parser.add_argument('--msvs_version', required=True)
args = parser.parse_args()
with utils.tmp_dir():
@@ -30,12 +30,9 @@ def main():
upload_script = os.path.join(common.FILE_DIR, 'upload.py')
try:
- cmd = ['python', create_script,
- '-t', cwd,
- '--msvs_version', args.msvs_version]
- if args.chrome_path:
- cmd.extend(['--chrome_path', args.chrome_path])
- subprocess.check_call(cmd)
+ subprocess.check_call(['python', create_script, '--target_dir', cwd,
+ '--chrome_src_path', args.chrome_src_path,
+ '--browser_executable', args.browser_executable])
cmd = ['python', upload_script, '-t', cwd]
if args.gsutil:
cmd.extend(['--gsutil', args.gsutil])
« no previous file with comments | « infra/bots/assets/skp/create.py ('k') | infra/bots/assets/skp/download.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698