Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2167733002: Simplify "is external URL" in filter operations resolving (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
Stephen Chennney
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify "is external URL" in filter operations resolving We've already resolved the URL, so we might as well just use equalIgnoringFragmentIdentifier on that rather than potentially re-resolve and compare. No functional change. Eventually we'll need to have the URL resolved before style resolution. BUG=470608, 405315 Committed: https://crrev.com/1e10ae9fded23fccb138a01b662df295c4cf57d3 Cr-Commit-Position: refs/heads/master@{#406574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
fs
4 years, 5 months ago (2016-07-20 15:21:58 UTC) #4
Stephen Chennney
Test? The bug reports seem to imply that a test can be constructed.
4 years, 5 months ago (2016-07-20 15:37:08 UTC) #5
fs
On 2016/07/20 at 15:37:08, schenney wrote: > Test? The bug reports seem to imply that ...
4 years, 5 months ago (2016-07-20 15:43:20 UTC) #6
Stephen Chennney
On 2016/07/20 15:43:20, fs wrote: > On 2016/07/20 at 15:37:08, schenney wrote: > > Test? ...
4 years, 5 months ago (2016-07-20 15:45:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167733002/1
4 years, 5 months ago (2016-07-20 16:15:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 16:20:43 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:21:04 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 16:22:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e10ae9fded23fccb138a01b662df295c4cf57d3
Cr-Commit-Position: refs/heads/master@{#406574}

Powered by Google App Engine
This is Rietveld 408576698