Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2167733002: Simplify "is external URL" in filter operations resolving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
index ffcde3df647e1c5efed20c04e8564a7a0e6abee9..d41a8cfe79af2de57cee6ad81d6c7a4ea327bfc7 100644
--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
@@ -34,8 +34,6 @@
#include "core/css/resolver/StyleResolverState.h"
#include "core/frame/UseCounter.h"
#include "core/layout/svg/ReferenceFilterBuilder.h"
-#include "core/svg/SVGElement.h"
-#include "core/svg/SVGURIReference.h"
namespace blink {
@@ -139,7 +137,7 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt
KURL url = state.document().completeURL(svgDocumentValue.url());
ReferenceFilterOperation* operation = ReferenceFilterOperation::create(svgDocumentValue.url(), AtomicString(url.fragmentIdentifier()));
- if (SVGURIReference::isExternalURIReference(svgDocumentValue.url(), state.document())) {
+ if (!equalIgnoringFragmentIdentifier(url, state.document().url())) {
if (!svgDocumentValue.loadRequested())
state.elementStyleResources().addPendingSVGDocument(operation, &svgDocumentValue);
else if (svgDocumentValue.cachedSVGDocument())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698